Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: CacheKVStore dirty items sorted #3677

Closed
wants to merge 4 commits into from

Conversation

mossid
Copy link
Contributor

@mossid mossid commented Feb 18, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

Closes: #2286


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mossid mossid added WIP and removed WIP labels Feb 18, 2019
@mossid mossid marked this pull request as ready for review February 19, 2019 13:31
@mossid mossid changed the title CacheKVStore dirty items sorted WIP: CacheKVStore dirty items sorted Feb 21, 2019
@mossid mossid force-pushed the joon/2286-cachekv-sorted-dirty branch from 88787ad to 6e5e0dd Compare February 26, 2019 18:42
@alexanderbez
Copy link
Contributor

bump @mossid -- any updates you can share on this?

@alexanderbez
Copy link
Contributor

bump @mossid

@cwgoes
Copy link
Contributor

cwgoes commented Mar 24, 2019

This is a good idea regardless, but if it's a significant amount of work I don't think it's super high-priority - we might be better served by writing more extensive gaiad benchmarks first. Up to you @mossid.

@ebuchman ebuchman closed this Apr 26, 2019
@alessio alessio deleted the joon/2286-cachekv-sorted-dirty branch June 15, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants