Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix keys add --interactive regression #3731

Merged
merged 2 commits into from
Feb 25, 2019
Merged

R4R: Fix keys add --interactive regression #3731

merged 2 commits into from
Feb 25, 2019

Conversation

jackzampolin
Copy link
Member

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jackzampolin jackzampolin added this to the v0.33.0 (Launch) milestone Feb 25, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I have not tested locally. I also recall seeing an issue for this recently, but it seems to be deleted? If it does exist, I recommend referencing that.

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #3731 into develop will increase coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3731      +/-   ##
===========================================
+ Coverage    61.18%   61.19%   +0.01%     
===========================================
  Files          190      190              
  Lines        14042    14042              
===========================================
+ Hits          8591     8593       +2     
+ Misses        4913     4911       -2     
  Partials       538      538

@jackzampolin jackzampolin merged commit 250dc98 into develop Feb 25, 2019
@jackzampolin jackzampolin deleted the jack/bip branch February 25, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants