Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Return on zero-length byte array input #3745

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Feb 26, 2019

Closes #3727

cc @mossid

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@mossid mossid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :+1

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #3745 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3745      +/-   ##
===========================================
- Coverage    61.15%   61.13%   -0.02%     
===========================================
  Files          189      189              
  Lines        14052    14052              
===========================================
- Hits          8593     8591       -2     
- Misses        4921     4923       +2     
  Partials       538      538

@cwgoes cwgoes changed the title Return on zero-length byte array input R4R: Return on zero-length byte array input Feb 26, 2019
@cwgoes cwgoes added this to the v0.33.0 (Launch) milestone Feb 26, 2019
@cwgoes cwgoes merged commit b86afd8 into develop Feb 26, 2019
@cwgoes cwgoes deleted the cwgoes/return-on-zero-length branch February 26, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants