R4R: Simulation Refactor

[rigelrozanski]

replaces #3744

• simulations saved in ~/.gaiad/simulations/ (with smaller name only the time, without spaces)
• "lean" simulation output option to exclude No-ops and !ok functions (--SimulationLean flag)
• getSimulateFromSeedInput helper function to improve setup in cmd/gaia/app/sim_test.go
• standardize simulation output, begin building in json simulation output for simulation re-running
• cleanup bank simulation messages / remove dup code in bank simulation
• simulation moved to its own module (not a part of mock)
• logger type instead of passing function variables everywhere
• logger json output (for reloadable simulation running)

---

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added entries in PENDING.md with issue #
• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #3819 into develop will decrease coverage by <.01%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop    #3819      +/-   ##
===========================================
- Coverage    60.95%   60.95%   -0.01%     
===========================================
  Files          192      192              
  Lines        14360    14359       -1     
===========================================
- Hits          8753     8752       -1     
  Misses        5033     5033              
  Partials       574      574

[alexanderbez]

Remove this commented out code.

[cwgoes]

Generally the structural changes make sense to me, several comments.

Have you tried replicating a simulation from the log messages (is that the intent)?

[rigelrozanski]

@cwgoes

Have you tried replicating a simulation from the log messages (is that the intent)?

This is definitely the intent. The next step which is not included in this PR is the replication the simulation, I stopped short of following through with that to focus more on actual bug huntin'. Although a lot of the required high level structure is now here, there is a little more thinking/refactors required before that can be achieved surrounding the generation and storage of random parameters.

[cwgoes]

ACK