Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create delegator-guide-cli.md #3827

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Conversation

shirleypyj
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@fbd79d0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #3827   +/-   ##
==========================================
  Coverage           ?   60.92%           
==========================================
  Files              ?      192           
  Lines              ?    14307           
  Branches           ?        0           
==========================================
  Hits               ?     8717           
  Misses             ?     5024           
  Partials           ?      566

1 similar comment
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@fbd79d0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #3827   +/-   ##
==========================================
  Coverage           ?   60.92%           
==========================================
  Files              ?      192           
  Lines              ?    14307           
  Branches           ?        0           
==========================================
  Hits               ?     8717           
  Misses             ?     5024           
  Partials           ?      566

@jackzampolin jackzampolin merged commit c57de3d into cosmos:develop Mar 8, 2019
@jackzampolin
Copy link
Member

Thank you @shirleypyj 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants