Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Add indent to JSON of gaiacli key [add|show|list] #3841

Merged
merged 6 commits into from
Mar 13, 2019
Merged

R4R: Add indent to JSON of gaiacli key [add|show|list] #3841

merged 6 commits into from
Mar 13, 2019

Conversation

yangyanqing
Copy link
Contributor

@yangyanqing yangyanqing commented Mar 9, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.(Just print format)

  • Wrote tests (Just print format, but I had tested)

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #3841 into develop will decrease coverage by <.01%.
The diff coverage is 60%.

@@             Coverage Diff             @@
##           develop    #3841      +/-   ##
===========================================
- Coverage    60.92%   60.92%   -0.01%     
===========================================
  Files          192      192              
  Lines        14323    14331       +8     
===========================================
+ Hits          8727     8731       +4     
- Misses        5027     5031       +4     
  Partials       569      569

@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #3841 into develop will decrease coverage by 0.01%.
The diff coverage is 64.7%.

@@             Coverage Diff             @@
##           develop    #3841      +/-   ##
===========================================
- Coverage    60.94%   60.92%   -0.02%     
===========================================
  Files          192      192              
  Lines        14346    14337       -9     
===========================================
- Hits          8743     8735       -8     
+ Misses        5033     5029       -4     
- Partials       570      573       +3

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this PR make the usage of --indent consistent across the keys package. I've noted the two other commands that need to be similarly amended.

Also there needs to be an entry in PENDING.md for this change as well. Thank you for your contribution!

@yangyanqing yangyanqing changed the title Add indent to JSON of gaiacli key list Add indent to JSON of gaiacli key [add|show|list] Mar 11, 2019
CHANGELOG.md Outdated Show resolved Hide resolved
@yangyanqing yangyanqing changed the title Add indent to JSON of gaiacli key [add|show|list] R4R: Add indent to JSON of gaiacli key [add|show|list] Mar 13, 2019
@alexanderbez
Copy link
Contributor

LGTM. Lets get this merged @jackzampolin

Add indent to JSON of `gaiacli key [add|show|list]`

Co-Authored-By: yangyanqing <yangyanqing.cn@gmail.com>
@jackzampolin jackzampolin merged commit 54ac1d2 into cosmos:develop Mar 13, 2019
@yangyanqing yangyanqing deleted the frank/keys-list-indent branch March 13, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants