Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CircleCI for Tags #3849

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Fix: CircleCI for Tags #3849

merged 1 commit into from
Mar 11, 2019

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Mar 11, 2019

  • Fixes: CircleCI tag release not triggered #3848

  • force setup_dependencies to run also for tags

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@4b765b6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #3849   +/-   ##
==========================================
  Coverage           ?   60.92%           
==========================================
  Files              ?      192           
  Lines              ?    14323           
  Branches           ?        0           
==========================================
  Hits               ?     8727           
  Misses             ?     5027           
  Partials           ?      569

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit 42718b5 into develop Mar 11, 2019
@cwgoes cwgoes deleted the sabau/fix-circleci-tags branch March 11, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants