Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Disable Keybase for Generate Only #3960

Merged
merged 5 commits into from
Mar 25, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 21, 2019

When --generate-only is provided, the Keybase is not used and as a result the --from value must be a valid Bech32 cosmos address -- this is exactly what the REST client enforces. So now it's consistent.

closes: #3889


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #3960 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3960   +/-   ##
========================================
  Coverage    60.43%   60.43%           
========================================
  Files          196      196           
  Lines        14492    14492           
========================================
  Hits          8758     8758           
  Misses        5154     5154           
  Partials       580      580

@alexanderbez alexanderbez marked this pull request as ready for review March 22, 2019 01:24
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a sdkch entry - otherwise ACK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to generate delegation transaction with --generate-only without a key in the keybase
3 participants