Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Proposal Stringer #3986

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Fix Proposal Stringer #3986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d728ed
Fix Proposal Stringer
alexanderbez Mar 27, 2019
6f58ab7
Add pending log entry
alexanderbez Mar 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pending/improvements/sdk/3986-Update-the-Stringer-implementation-of-the-Proposal-type
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#3986 Update the Stringer implementation of the Proposal type.
21 changes: 12 additions & 9 deletions x/gov/proposals.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,19 @@ type Proposal struct {
// nolint
func (p Proposal) String() string {
return fmt.Sprintf(`Proposal %d:
Title: %s
Type: %s
Status: %s
Submit Time: %s
Deposit End Time: %s
Total Deposit: %s
Voting Start Time: %s
Voting End Time: %s`, p.ProposalID, p.GetTitle(), p.ProposalType(),
Title: %s
Type: %s
Status: %s
Submit Time: %s
Deposit End Time: %s
Total Deposit: %s
Voting Start Time: %s
Voting End Time: %s
Description: %s`,
p.ProposalID, p.GetTitle(), p.ProposalType(),
p.Status, p.SubmitTime, p.DepositEndTime,
p.TotalDeposit, p.VotingStartTime, p.VotingEndTime)
p.TotalDeposit, p.VotingStartTime, p.VotingEndTime, p.GetDescription(),
)
}

// ProposalContent is an interface that has title, description, and proposaltype
Expand Down