Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Provide support for Cosmos App v1.5.0 (ledger) #3997

Closed
wants to merge 12 commits into from
Closed

WIP: Provide support for Cosmos App v1.5.0 (ledger) #3997

wants to merge 12 commits into from

Conversation

jleni
Copy link
Member

@jleni jleni commented Mar 28, 2019 •
edited
Loading

This PR adds support for the latest version of the Cosmos App (v.1.3.1)
Attention: The app is not been released yet by Ledger. Do not merge yet.

When creating a new account, gaiacli now shows the account/index and address in the device and requires user confirmation.

Related PRs:
cosmos/ledger-cosmos-go#3
cosmos/ledger-cosmos-go#4

Changes in the app can be found here:
https://github.com/cosmos/ledger-cosmos/pull/128

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jleni jleni changed the title WIP: Provide support for Cosmos App v1.3.1 (ledger) R4R: Provide support for Cosmos App v1.3.1 (ledger) Apr 1, 2019
@jleni jleni changed the title R4R: Provide support for Cosmos App v1.3.1 (ledger) WIP: Provide support for Cosmos App v1.3.1 (ledger) Apr 1, 2019
@jleni
Copy link
Member Author

jleni commented Apr 1, 2019

This PR adds support for v1.3.1 but the app has not been released yet.
I will back the PR backwards compatible and to show a warning if the old app is being used.
In the future, we can merge a second PR go force the upgrade to 1.3.1

@jleni jleni force-pushed the fix/app_v1.3 branch 3 times, most recently from ef0f8f2 to e99a0c6 Compare April 1, 2019 08:00
jleni
jleni commented Apr 1, 2019
View reviewed changes
Copy link
Member Author

@jleni jleni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot block myself so please do not merge yet

go.sum Outdated
@@ -146,6 +153,7 @@ github.com/tendermint/go-amino v0.14.1 h1:o2WudxNfdLNBwMyl2dqOJxiro5rfrEaU0Ugs6o
github.com/tendermint/go-amino v0.14.1/go.mod h1:i/UKE5Uocn+argJJBb12qTZsCDBcAYMbR92AaJVmKso=
github.com/tendermint/iavl v0.12.1 h1:JDfyhM/Hhrumu1CL1Nxrypm8sNTPYqmeHo1IZLiJoXM=
github.com/tendermint/iavl v0.12.1/go.mod h1:EoKMMv++tDOL5qKKVnoIqtVPshRrEPeJ0WsgDOLAauM=
github.com/tendermint/tendermint v0.29.1/go.mod h1:ymcPyWblXCplCPQjbOYbrF1fWnpslATMVqiGgWbZrlc=
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this is happening here

@jleni jleni force-pushed the fix/app_v1.3 branch 2 times, most recently from cd2ba55 to 4de3866 Compare April 3, 2019 08:29
@fedekunze
Copy link
Collaborator

de we need to update this to 1.3.2 ?

@jleni
Copy link
Member Author

jleni commented Apr 9, 2019

well, there is no real functionality in 1.3.2, it is a patch release (only the last number changes), so this PR should be fully compatible.
We can still update it. I will check what are these new conflicts later today.

Btw, the PR for the app has already been submitted to Ledger and is under review.
LedgerHQ/ledger-app-cosmos#4

@jleni
Copy link
Member Author

jleni commented Apr 24, 2019

Ledger has received a new submission for Cosmos App v1.5
LedgerHQ/ledger-app-cosmos#5

I will update this PRs to align with those changes

@fedekunze fedekunze changed the title WIP: Provide support for Cosmos App v1.3.1 (ledger) WIP: Provide support for Cosmos App v1.5.0 (ledger) Apr 24, 2019
@fedekunze fedekunze added C:Ledger Issues and features related Ledger integration and functionality WIP labels Apr 24, 2019
@jleni jleni closed this Apr 25, 2019
@jleni
Copy link
Member Author

jleni commented Apr 25, 2019

I will resubmit a new cleaner PR specific for v1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees
No one assigned
Labels
C:Ledger Issues and features related Ledger integration and functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleni @fedekunze