Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.33.1 zero export bugfix #3999

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Conversation

rigelrozanski
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #3999 into release/v0.33.1 will decrease coverage by 0.03%.
The diff coverage is 0%.

@@                 Coverage Diff                 @@
##           release/v0.33.1    #3999      +/-   ##
===================================================
- Coverage            60.89%   60.85%   -0.04%     
===================================================
  Files                  192      192              
  Lines                14288    14289       +1     
===================================================
- Hits                  8700     8696       -4     
- Misses                5021     5026       +5     
  Partials               567      567

@alexanderbez
Copy link
Contributor

Do we need a pendinglog entry here or a changelog entry here @alessio?

@rigelrozanski
Copy link
Contributor Author

We would want a changelog entry in the actual release

@alessio
Copy link
Contributor

alessio commented Mar 28, 2019

Pending entry is fine. Who handle the release will generate the new changelog I guess, don't they? @jackzampolin @alexanderbez

cmd/gaia/app/export.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@@ -0,0 +1 @@
#3656 distribution delegation zero export bugfix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hang on, 3656 is #3656. Is it correct to link the two?

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going directly into a hotfix release. I think therefor there should be no pending log entry, but rather a direct change log entry pointing to the PR #3999 instead of the original PR.

@alexanderbez alexanderbez merged commit da17a6d into release/v0.33.1 Apr 2, 2019
@alexanderbez alexanderbez deleted the rigel/zero-export-butv0331 branch April 2, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants