Block Time in Txs Response #4007
Conversation
alexanderbez
added
WIP
Type: Code Hygiene
Codecov Report
@@ Coverage Diff @@
## develop #4007 +/- ##
===========================================
- Coverage 59.76% 59.75% -0.02%
===========================================
Files 211 211
Lines 15055 15058 +3
===========================================
Hits 8998 8998
- Misses 5435 5438 +3
Partials 622 622 |
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
| } | ||
|
|
||
| // NewResponseResultTx returns a TxResponse given a ResultTx from tendermint | ||
| func NewResponseResultTx(res *ctypes.ResultTx, tx Tx) TxResponse { | ||
| func NewResponseResultTx(res *ctypes.ResultTx, tx Tx, timestamp string) TxResponse { |
There was a problem hiding this comment.
Can we get a test case for this? It would give a tiny boost to our coverage report
There was a problem hiding this comment.
A test case for the constructor?
There was a problem hiding this comment.
I know, it sounds dumb but it'd be easy and we would reduce the impact on the coverage report
| res, err := node.TxSearch(query, prove, page, perPage) | ||
| if err != nil { | ||
| return nil, err | ||
| func queryTxs(cliCtx context.CLIContext, cdc *codec.Codec, tag string, delegatorAddr string) ([]sdk.TxResponse, error) { |
There was a problem hiding this comment.
actually I think we can delete the staking query tx endpoint. It's a dup from regular tx query, the main difference is that you don't need to specify tags, which is silly
There was a problem hiding this comment.
^^ would be api-breaking
There was a problem hiding this comment.
Agreed, but let's save that for another issue/PR -- would like to avoid as much scope creep as possible. Mind opening an issue?
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
TxResponsewhen querying for tx(s)query.goutils.gocloses: #3238
/cc @faboweb @dogemos
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: