Hex Encode Data in Tx Responses #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
the
T: API Breaking
Codecov Report
@@ Coverage Diff @@
## develop #4028 +/- ##
========================================
Coverage 60.02% 60.02%
========================================
Files 212 212
Lines 15104 15104
========================================
Hits 9066 9066
Misses 5417 5417
Partials 621 621 |
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
fedekunze
reviewed
Apr 2, 2019
fedekunze
reviewed
Apr 2, 2019
| if r.Data != nil { | ||
| sb.WriteString(fmt.Sprintf(" Data: %s\n", string(r.Data))) | ||
| if r.Data != "" { | ||
| sb.WriteString(fmt.Sprintf(" Data: %s\n", r.Data)) |
There was a problem hiding this comment.
can we use tab \t in this function?
Suggested change
| sb.WriteString(fmt.Sprintf(" Data: %s\n", r.Data)) | |
| sb.WriteString(fmt.Sprintf("\tData: %s\n", r.Data)) |
There was a problem hiding this comment.
oh no, please don't.... I'd even remove the trailing \n
There was a problem hiding this comment.
lol...the tab vs space war begins. idc really (go's standard is tabs actually), but I'd rather be consistent. What to do?
jackzampolin
approved these changes
Apr 3, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3916
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: