Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix /txs/encode endpoint #4147

Closed
wants to merge 2 commits into from
Closed

Fix /txs/encode endpoint #4147

wants to merge 2 commits into from

Conversation

yangyanqing
Copy link
Contributor

@yangyanqing yangyanqing commented Apr 17, 2019 •
edited by alexanderbez
Loading

closes: #4141

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 17, 2019 •
edited
Loading

Codecov Report

Merging #4147 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4147      +/-   ##
===========================================
- Coverage    60.17%   60.16%   -0.02%     
===========================================
  Files          212      212              
  Lines        15187    15187              
===========================================
- Hits          9139     9137       -2     
- Misses        5419     5421       +2     
  Partials       629      629

fedekunze
fedekunze suggested changes Apr 17, 2019
View reviewed changes
client/lcd/swagger-ui/swagger.yaml Outdated Show resolved Hide resolved
@alexanderbez alexanderbez changed the title Make /txs/encode compatible with gaiacli tx send --generate-only. Fix /txs/encode endpoint Apr 17, 2019
@alexanderbez alexanderbez added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. ready-for-review labels Apr 17, 2019
alexanderbez
alexanderbez suggested changes Apr 17, 2019
View reviewed changes
.pending/bugfixes/gaiarest/4141-Make-compatible Outdated Show resolved Hide resolved
client/tx/encode.go Outdated Show resolved Hide resolved
@yangyanqing
Copy link
Contributor Author

We need more discussion first. #4141 (comment)

alexanderbez
alexanderbez suggested changes Apr 23, 2019
View reviewed changes
client/tx/encode.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez requested a review from fedekunze April 25, 2019 13:07
@ebuchman ebuchman closed this Apr 26, 2019
@alexanderbez
Copy link
Contributor

Sorry @yangyanqing, but we revamped our git flow process -- we have a single canonical branch master. Do you mind re-opening a new PR against master.

@yangyanqing
Copy link
Contributor Author

ok, that's all right @alexanderbez

@yangyanqing yangyanqing deleted the frank/4141-tx-encode-fit-cli branch April 27, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yangyanqing @alexanderbez @fedekunze @ebuchman