-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Staking Validators Rest Query #4177
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4177 +/- ##
===========================================
- Coverage 60.19% 60.18% -0.01%
===========================================
Files 212 212
Lines 15167 15187 +20
===========================================
+ Hits 9130 9141 +11
- Misses 5412 5417 +5
- Partials 625 629 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Side note, we should probably abstract the pagination functionality into a util to reuse it on other queriers as well.
0a26f71
to
39e6290
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Has this been tested on the CLI? There are no new cli flags in this PR (gaiacli query staking validators
)
Thanks for the review @rigelrozanski -- I addressed all your comments. With regards to the CLI, that was left untouched because the CLI and REST never implemented the same functionality really (ie. the CLI just returns all validators always). Should we change this too? |
Support pagination and bond status query params in the
/staking/validators
REST endpoint. The default number of validators returned is the max number of bonded validators and the default status is bonded.closes: #4099
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: