-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Param Change Proposal #4206
Param Change Proposal #4206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! - Good design, and nice refactors.
general comments on the docs, and code structure - nothing too big.
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #4206 +/- ##
==========================================
+ Coverage 60.17% 60.45% +0.27%
==========================================
Files 212 218 +6
Lines 15187 15355 +168
==========================================
+ Hits 9139 9283 +144
- Misses 5419 5432 +13
- Partials 629 640 +11 |
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
…os-sdk into 3565-param-change-proposal-4
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
@rigelrozanski @cwgoes @mossid I've addressed all your comments :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
This PR addresses the implementation of parameter change proposals. It's major features and changes include:
x/param
moduletypes/
packageParameterChangeProposal
andParamChange
typesx/gov
moduletypes/
packageSoftwareUpgrade
proposalsContent
andHandler
interfacesContent
router in the keeperEndBlocker
to executeContent
handlerThis is state machine breaking. The proposal's
Content
JSON field has been renamed andSoftwareUpgrade
are temporarily disabled.A follow up PR should be made to add param change proposals to simulation.
replaces/supersedes: #3880
closes: #3565
credit: @mossid
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: