Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AppendTags usage error #4336

Merged
merged 2 commits into from
May 14, 2019
Merged

Fix AppendTags usage error #4336

merged 2 commits into from
May 14, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 14, 2019

This change set adds a pending entry file
to @mjackson001's original PR: #4274

Closes: #4273

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio requested review from sabau and fedekunze May 14, 2019 10:23
@alessio alessio mentioned this pull request May 14, 2019
Closed
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #4336 into master will decrease coverage by 0.3%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4336      +/-   ##
==========================================
- Coverage    59.4%   59.09%   -0.31%     
==========================================
  Files         214      217       +3     
  Lines       14533    14595      +62     
==========================================
- Hits         8633     8625       -8     
- Misses       5262     5332      +70     
  Partials      638      638

alexanderbez
alexanderbez approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alessio alessio merged commit 262c752 into master May 14, 2019
@alessio alessio deleted the pr-4274 branch May 14, 2019 15:13
alexanderbez pushed a commit that referenced this pull request May 23, 2019
@alexanderbez
Cherry Pick PR #4336: Fix AppendTags usage error
d476554
@alexanderbez alexanderbez mentioned this pull request May 23, 2019
Merged
5 tasks
alexanderbez added a commit that referenced this pull request May 23, 2019
@alexanderbez
Merge PR #4400: Release v0.34.5 - RC1
c7c8bbd 
* Cherry Pick PR #4345: Upgrade ledger-cosmos-go

* Cherry Pick PR #4336: Fix AppendTags usage error

* Update modules

* Cherry Pick PR #4265: CacheKVStore keep sorted items

* Cherry Pick #4227: Adding support for Ledger Cosmos App v1.5

* Cherry Pick #4395: Improve sig verification error message

* Cherry Pick PR #4140: Fix Failed Simulation Seeds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppendTags usage issue in x/staking/handler.go
3 participants
@alessio @alexanderbez @fedekunze