R4R: Paramchange proposal skips omitempty fields #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossid
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4403 +/- ##
==========================================
+ Coverage 57.21% 57.27% +0.06%
==========================================
Files 241 242 +1
Lines 15123 15149 +26
==========================================
+ Hits 8653 8677 +24
- Misses 5840 5841 +1
- Partials 630 631 +1 |
fedekunze
reviewed
May 23, 2019
alexanderbez
suggested changes
May 23, 2019
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
golangcibot
reviewed
May 23, 2019
|
I realized that simulated tally params are hard-coded and I also added governance param changes to simulation. One of those two things broke CI -- I'm looking into it. |
|
Looks like CI is fixed here! Are we good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4247
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: