remove ICS categories from swagger

[hschoenburg]

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added a relevant changelog entry: clog add [section] [stanza] [message]

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[alexanderbez]

ACK

[alexanderbez]

@hschoenburg we now commit the generated statik file. Please run: make update-swagger-docs and commit the resulting file :)

[alexanderbez]

ACK -- needs swagger docs build updated.

[fedekunze]

Thanks Hans ! Few things missing:

• /auth/accounts/{address} is still under ICS1 tag, should have tag Auth
• Missing Mint tag for mint requests
• GET /node_info is duplicated, need to delete the one with Misc tag

[hschoenburg]

Thanks for the comments guys. I added a newly generated statik.go, as well as Auth and Mint tags. @fedekunze I wasn't completely clear on which node_* endpoint was duplicate but I think I removed the right one (with the Misc tag).

[fedekunze]

ACK

[fedekunze]

check_statik test failing

[hschoenburg]

sorry forgot to fix the statik.go check until now. Lmk if there is anything more I can do here. Looks like the PR needs to be merged locally because of the statik.go conflict.

[alexanderbez]

There is a conflict @hschoenburg. Perhaps the statik file you generated should be the one committed. How did you generate it?

[hschoenburg]

There is a conflict @hschoenburg. Perhaps the statik file you generated should be the one committed. How did you generate it?

@alexanderbez >> thanks for following up. Since this PR makes changes to the swagger.yaml I imagine the statik.go in this branch is the one that should be merged into master. After committing the changes to swagger.yaml I ran $ make update-swagger-docs and committed the new statik.go file. Was that the right process? The statik check it passing now. But because of the conflict I think this merge needs to be done locally?

[alexanderbez]

That is the correct process @hschoenburg -- simply commit your statik.go file in favor of the one on master to resolve the conflicts :)

[sabau]

Shouldn't we remove also the implementation along with the documentation? Or we end up having those two working but not documented:

• /staking/delegators/{delegatorAddr}/txs

[fedekunze]

need to resolve conflicts and add clog entry

[fedekunze]

@hschoenburg can we have this for the release next week?

[codecov]

Codecov Report

Merging #4429 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4429   +/-   ##
=======================================
  Coverage   52.75%   52.75%           
=======================================
  Files         264      264           
  Lines       16464    16464           
=======================================
  Hits         8685     8685           
  Misses       7130     7130           
  Partials      649      649

[tac0turtle]

need to resolve conflicts and add clog entry

decided to not add a clog entry, spoke with team in berlin

[alexanderbez]

ACK -- no pending log entry needed imho.

[tac0turtle]

also, the commit message steemed from something else I apologize for it

[fedekunze]

utACK