Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add goconst to enabled linters #4591

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Add goconst to enabled linters #4591

merged 1 commit into from
Jun 19, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jun 19, 2019 •
edited by alexanderbez
Loading

Partially address #4589

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #4591 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4591      +/-   ##
==========================================
+ Coverage   52.75%   52.76%   +0.01%     
==========================================
  Files         264      264              
  Lines       16464    16464              
==========================================
+ Hits         8685     8687       +2     
+ Misses       7130     7128       -2     
  Partials      649      649

@alexanderbez alexanderbez added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Jun 19, 2019
alexanderbez
alexanderbez approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

sabau
sabau approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal as I like ❤️

@alessio alessio merged commit e12876c into master Jun 19, 2019
@alessio alessio deleted the alessio/add-goconst-to-linters branch June 19, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@sabau sabau sabau approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@fedekunze fedekunze Awaiting requested review from fedekunze

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @sabau @alexanderbez