Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supply querier #4592

Merged
merged 189 commits into from
Jul 1, 2019
Merged

supply querier #4592

merged 189 commits into from
Jul 1, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jun 19, 2019 •
edited
Loading

closes #4082

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze and others added 30 commits May 2, 2019 15:17
@fedekunze
supply module
e8533ee
@fedekunze
invariants
0866d2e
@fedekunze
add to gaia, tests, minor fixes
89a54e4
@fedekunze
tests
cf02698
@fedekunze
fixes
7f3a5c9
@fedekunze
expected crisis keeper
e19d098
@fedekunze
accounts
d2c13a6
@fedekunze
supply bank
bb12b4f
@fedekunze
total supply type and keeper
1983151
@alexanderbez @fedekunze
Apply suggestions from code review
ce46707 
Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
@fedekunze
cleanup app.go
26c4804
@fedekunze
Merge branch 'fedekunze/3972-supply' of https://github.com/cosmos/cos…
f67852b 
…mos-sdk into fedekunze/3972-supply
@fedekunze
genesis stuff
7200d2e
@fedekunze
fix error checks
8940db4
@fedekunze
gov module holder account
eeaa0c3
@fedekunze
some gov tests
bc314a9
@fedekunze
remove fee collector keeper and staking pool
739673a
@fedekunze
more fixes on staking
03564c1
@fedekunze
fix gov supplyKeeper
d59b287
@fedekunze
remove staking pool fixes
249ae59
@fedekunze
fix mock mod
1dda132
@fedekunze
more staking pool changes
06c65d7
@fedekunze
more changes in tests
1186198
@fedekunze
remove fee pool from store
fe1e028
@fedekunze
extend pool accs to use DecCoins instead of Coins
7afdfad
@fedekunze
revert DecCoins
310f566
@fedekunze
some build fixes
6f38715
@fedekunze
revert changes from distr
1cf75b6
@fedekunze
cleanup supply module's bank logic
a93874c
@fedekunze
cleanup supply, remove inflate/deflate exported funcs
8fe8afb
fedekunze and others added 8 commits June 28, 2019 18:38
@fedekunze @alexanderbez
Update x/slashing/keeper.go
6224dda 
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@fedekunze @alexanderbez
Update x/slashing/keeper.go
ef2c8c2 
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@fedekunze @alexanderbez
Update x/slashing/keeper.go
8b29a19 
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@fedekunze @alexanderbez
Update x/slashing/keeper.go
d7a9ca0 
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@fedekunze @alexanderbez
Update x/slashing/keeper.go
c78f378 
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@fedekunze
address final @alexanderbez comments
bdeea26
@fedekunze
Merge branch 'fedekunze/3972-supply' of https://github.com/cosmos/cos…
a1d0001 
…mos-sdk into fedekunze/3972-supply
@fedekunze
Merge branch 'fedekunze/3972-supply' of https://github.com/cosmos/cos…
db22422 
…mos-sdk into fedekunze/4082-supply-querier
@alexanderbez alexanderbez changed the base branch from fedekunze/3972-supply to master June 28, 2019 20:11
@fedekunze fedekunze removed the S:blocked Status: Blocked label Jun 28, 2019
AdityaSripal
AdityaSripal approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aayushijain23
aayushijain23 approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@aayushijain23 aayushijain23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

colin-axner
colin-axner approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a note for myself for updating supply REST endpoints

x/supply/client/rest/query.go Outdated Show resolved Hide resolved
x/supply/client/rest/query.go Outdated Show resolved Hide resolved
alessio
alessio suggested changes Jun 29, 2019
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Route paths should be snake_case - so they are elsewhere in the codebase.

x/supply/types/querier.go Outdated Show resolved Hide resolved
x/supply/types/querier.go Outdated Show resolved Hide resolved
@fedekunze @alessio
Address @alessio 's suggestions
57d38be 
Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
@fedekunze fedekunze requested a review from alessio June 29, 2019 19:12
@alessio
Copy link
Contributor

alessio commented Jun 30, 2019

Thanks @fedekunze - tests fail now

@alessio alessio dismissed alexanderbez’s stale review July 1, 2019 11:30

Suggestions have been incorporated. Hence dismissing in order to merge

@alessio alessio merged commit 48e8161 into master Jul 1, 2019
@alessio alessio deleted the fedekunze/4082-supply-querier branch July 1, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@aayushijain23 aayushijain23 aayushijain23 approved these changes

@AdityaSripal AdityaSripal AdityaSripal approved these changes

@alessio alessio alessio approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@sabau sabau Awaiting requested review from sabau

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/supply: Implement Querier
8 participants
@fedekunze @alessio @alexanderbez @AdityaSripal @aayushijain23 @colin-axner @liamsi @rigelrozanski