WIP: Refactor crisis using internal package #4597
Conversation
alessio
requested review from
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
There was a problem hiding this comment.
the tags pkg should be deleted and tags.go moved to types as well as the expected_keepers.go. The keeper pkg should be in internal as well.
genesis.go needs to be split and one should remain in internal/types whereas the other should be in the root of the module
| feeCollectionKeeper FeeCollectionKeeper | ||
| distrKeeper distrKeeper | ||
| bankKeeper bankKeeper | ||
| feeCollectionKeeper feeCollectionKeeper | ||
| } | ||
|
|
||
| // NewKeeper creates a new Keeper object | ||
| func NewKeeper(paramSpace params.Subspace, invCheckPeriod uint, |
There was a problem hiding this comment.
Don't we want the keeper to also be internal? Currently, this is inconsistent with the changes made on bank.
There was a problem hiding this comment.
I'll move it across internal
Codecov Report
@@ Coverage Diff @@
## master #4597 +/- ##
==========================================
+ Coverage 52.75% 52.77% +0.02%
==========================================
Files 264 264
Lines 16464 16464
==========================================
+ Hits 8685 8689 +4
+ Misses 7130 7126 -4
Partials 649 649 |
|
@fedekunze and I had a conversation about this, and we agreed this be on hold until supply PR is merged in. Hence blocking this for now. |
alessio
changed the title
|
removed |
|
@alessio feel free to pick back up on this again 👍 |
|
Superseded by #4649 |
docs/)clog add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: