Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase server package's coverage by adding DONTCOVER #4603

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jun 20, 2019

Although ideally we really should find a way to test the server package
functionalities in isolation, we are in fact testing it by running the binaries.
This PR aims to increase the SDK's horrible coverage stats by largely
ignoring server.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #4603 into master will increase coverage by 0.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4603      +/-   ##
==========================================
+ Coverage   52.79%   53.51%   +0.71%     
==========================================
  Files         264      261       -3     
  Lines       16468    16234     -234     
==========================================
- Hits         8695     8688       -7     
+ Misses       7126     6900     -226     
+ Partials      647      646       -1

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK :-/

@alexanderbez alexanderbez merged commit 6672e70 into master Jun 20, 2019
@alexanderbez alexanderbez deleted the alessio/increase-coverage branch June 20, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants