-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/bank: Expected Keeeper #4605
x/bank: Expected Keeeper #4605
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4605 +/- ##
==========================================
+ Coverage 53.51% 53.52% +0.01%
==========================================
Files 261 261
Lines 16234 16234
==========================================
+ Hits 8688 8690 +2
+ Misses 6900 6898 -2
Partials 646 646 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
type AccountKeeper interface { | ||
NewAccountWithAddress(ctx sdk.Context, addr sdk.AccAddress) exported.Account | ||
|
||
GetAccount(ctx sdk.Context, addr sdk.AccAddress) exported.Account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alessio It's methods like this in interfaces which cause the need for x/{module}/exported
. i.e. I'd like to define some contract w/o importing the originating module (in this case x/auth
's alias.go
). This contract contains methods which operate on and/or return types that are unique to that module (in this case Account
). In order to use this contract successfully, I have to be able to import said types w/o having import cycle hell, hence x/{module}/exported
.
A continuation of @colin-axner's work...
closes: #4576
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: