Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/bank: Expected Keeeper #4605

Merged
merged 5 commits into from
Jun 24, 2019
Merged

x/bank: Expected Keeeper #4605

merged 5 commits into from
Jun 24, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jun 20, 2019

A continuation of @colin-axner's work...

closes: #4576


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #4605 into master will increase coverage by 0.01%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master    #4605      +/-   ##
==========================================
+ Coverage   53.51%   53.52%   +0.01%     
==========================================
  Files         261      261              
  Lines       16234    16234              
==========================================
+ Hits         8688     8690       +2     
+ Misses       6900     6898       -2     
  Partials      646      646

@alexanderbez alexanderbez added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. ready-for-review and removed WIP labels Jun 24, 2019
@alexanderbez alexanderbez marked this pull request as ready for review June 24, 2019 19:22
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.pending/improvements/sdk/4584-Update-bank-Kee Outdated Show resolved Hide resolved
type AccountKeeper interface {
NewAccountWithAddress(ctx sdk.Context, addr sdk.AccAddress) exported.Account

GetAccount(ctx sdk.Context, addr sdk.AccAddress) exported.Account
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessio It's methods like this in interfaces which cause the need for x/{module}/exported. i.e. I'd like to define some contract w/o importing the originating module (in this case x/auth's alias.go). This contract contains methods which operate on and/or return types that are unique to that module (in this case Account). In order to use this contract successfully, I have to be able to import said types w/o having import cycle hell, hence x/{module}/exported.

@alexanderbez alexanderbez merged commit b78c359 into master Jun 24, 2019
@alexanderbez alexanderbez deleted the bez/4576-bank-expected-keeper branch June 24, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use expected keeper for bank module
4 participants