Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snap badge from README #4614

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Remove snap badge from README #4614

merged 1 commit into from
Jun 24, 2019

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Jun 24, 2019

Remove reference to Snap Builds, they should be built on Gaia

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@sabau sabau added T:Docs Changes and features related to documentation. ready-for-review labels Jun 24, 2019
@sabau
Copy link
Contributor Author

sabau commented Jun 24, 2019

I would remove also the scripts if it's ok @alessio and make a follow up in gaia to move Snap over there

@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #4614 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4614      +/-   ##
==========================================
- Coverage   53.64%   53.62%   -0.02%     
==========================================
  Files         260      260              
  Lines       16176    16176              
==========================================
- Hits         8677     8675       -2     
- Misses       6853     6855       +2     
  Partials      646      646

@alessio alessio merged commit 52bb151 into master Jun 24, 2019
@alessio alessio deleted the sabau/remove-snap-badge branch June 24, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants