Module Structure Spec #4618
Merged
Module Structure Spec #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
T:Docs
Codecov Report
@@ Coverage Diff @@
## master #4618 +/- ##
=======================================
Coverage 53.62% 53.62%
=======================================
Files 260 260
Lines 16176 16176
=======================================
Hits 8675 8675
Misses 6855 6855
Partials 646 646 |
alexanderbez
requested review from
alessio,
jackzampolin and
rigelrozanski
as code owners
fedekunze
reviewed
Jun 25, 2019
rigelrozanski
approved these changes
Jun 25, 2019
5 tasks
fedekunze
approved these changes
Jun 25, 2019
alessio
reviewed
Jun 25, 2019
|
|
||
| ```shell | ||
| x/{module} | ||
| ├── client |
There was a problem hiding this comment.
How about flatten client further? I mean: instead of having cli and rest as subpackages, how about promoting them to live module top level and get rid of client?
There was a problem hiding this comment.
Hmmm, I don't this that is a wise idea. They're both clients and should be grouped as such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #4438
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: