Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interfaces docs + module interfaces #4755

Merged
merged 79 commits into from
Sep 17, 2019
Merged

Conversation

glozow
Copy link
Contributor

@glozow glozow commented Jul 21, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@glozow glozow changed the title Gloria/interfaces docs add interfaces docs + module interfaces Jul 22, 2019
@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #4755 into master-docs will increase coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           master-docs    #4755      +/-   ##
===============================================
+ Coverage        53.74%   53.75%   +0.01%     
===============================================
  Files              272      272              
  Lines            17103    17103              
===============================================
+ Hits              9192     9194       +2     
+ Misses            7224     7222       -2     
  Partials           687      687

Copy link
Contributor

@gamarin2 gamarin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed half, will do the other half tomorrow

@glozow glozow force-pushed the gloria/interfaces-docs branch from a492360 to 481ef7c Compare August 10, 2019 21:27
@gamarin2 gamarin2 merged commit 47c9a28 into master-docs Sep 17, 2019
@gamarin2 gamarin2 deleted the gloria/interfaces-docs branch September 17, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants