Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT spec #4766

Merged
merged 6 commits into from
Jul 30, 2019
Merged

NFT spec #4766

merged 6 commits into from
Jul 30, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jul 23, 2019

closes #4735

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #4766 into billy/nft will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           billy/nft    #4766      +/-   ##
=============================================
+ Coverage      51.68%   51.69%   +<.01%     
=============================================
  Files            310      310              
  Lines          19661    19663       +2     
=============================================
+ Hits           10162    10164       +2     
  Misses          8782     8782              
  Partials         717      717

@fedekunze fedekunze mentioned this pull request Jul 23, 2019
5 tasks
@okwme okwme changed the base branch from master to billy/nft July 29, 2019 17:44
@okwme
Copy link
Contributor

okwme commented Jul 29, 2019

Changed base to billy/nft

@okwme okwme marked this pull request as ready for review July 30, 2019 17:09
@okwme okwme merged commit 2e1fbb6 into billy/nft Jul 30, 2019
@okwme okwme deleted the billy-fedekunze/4735-nft-spec branch July 30, 2019 17:13
@fedekunze
Copy link
Collaborator Author

fedekunze commented Jul 30, 2019

@okwme hmm ideally this should be merged to master and independently from the code changes. The idea is for others to review it prior to merging the module itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants