Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON representation of event stats #4784

Merged
merged 8 commits into from
Jul 26, 2019
Merged

Conversation

fedekunze
Copy link
Collaborator

Closes: #4670

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze
Copy link
Collaborator Author

fedekunze commented Jul 25, 2019

New output from make test_sim_app_fast:

{
 "auth": {
  "deduct_fee": {
   "failure": 11,
   "ok": 69
  }
 },
 "bank": {
  "multisend": {
   "failure": 6,
   "ok": 114
  },
  "send": {
   "failure": 113,
   "ok": 1207
  }
 },
 "begin_block": {
  "evicence": {
   "ok": 129
  },
  "signing": {
   "missed": 477,
   "signed": 2141
  }
 },
 "distribution": {
  "set_withdraw_address": {
   "failure": 606
  },
  "withdraw_delegator_reward": {
   "failure": 619,
   "ok": 31
  },
  "withdraw_validator_commission": {
   "failure": 191,
   "ok": 392
  }
 },
 "end_block": {
  "validator_updates": {
   "added": 107,
   "kicked": 114,
   "updated": 733
  }
 },
 "gov": {
  "deposit": {
   "failure": 258,
   "ok": 960
  },
  "submit_proposal": {
   "failure": 39,
   "ok": 142
  }
 },
 "slashing": {
  "unjail": {
   "failure": 1248,
   "ok": 2
  }
 },
 "staking": {
  "begin_redelegate": {
   "failure": 1068,
   "ok": 19
  },
  "begin_unbonding": {
   "failure": 1,
   "ok": 1006
  },
  "create_validator": {
   "failure": 962,
   "ok": 106
  },
  "delegate": {
   "failure": 46,
   "ok": 991
  },
  "edit_validator": {
   "failure": 17,
   "ok": 25
  },
  "no-operation": {
   "failure": 752
  }
 }
}

@fedekunze fedekunze added the R4R label Jul 25, 2019
@fedekunze fedekunze marked this pull request as ready for review July 25, 2019 16:08
@fedekunze
Copy link
Collaborator Author

cc: @npinto for your convenience

@fedekunze fedekunze requested a review from mircea-c July 25, 2019 16:09
x/gov/simulation/msgs.go Outdated Show resolved Hide resolved
x/gov/simulation/msgs.go Outdated Show resolved Hide resolved
x/simulation/operation.go Outdated Show resolved Hide resolved
x/simulation/operation.go Outdated Show resolved Hide resolved
x/simulation/operation.go Outdated Show resolved Hide resolved
x/simulation/operation.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #4784 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4784   +/-   ##
=======================================
  Coverage   53.89%   53.89%           
=======================================
  Files         270      270           
  Lines       17230    17230           
=======================================
  Hits         9286     9286           
  Misses       7260     7260           
  Partials      684      684

Copy link

@mircea-c mircea-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK but one minor nit

simapp/sim_test.go Show resolved Hide resolved
.pending/improvements/modules/_4670-JSON-sim-stats Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 24b9e84 into master Jul 26, 2019
@alexanderbez alexanderbez deleted the fedekunze/4670-json-sim-stats branch July 26, 2019 20:09
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulator: json output representation of the event statistics?
5 participants