-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON representation of event stats #4784
Conversation
New output from
|
cc: @npinto for your convenience |
Co-Authored-By: Alessio Treglia <alessio@tendermint.com>
…smos/cosmos-sdk into fedekunze/4670-json-sim-stats
Codecov Report
@@ Coverage Diff @@
## master #4784 +/- ##
=======================================
Coverage 53.89% 53.89%
=======================================
Files 270 270
Lines 17230 17230
=======================================
Hits 9286 9286
Misses 7260 7260
Partials 684 684 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK but one minor nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Closes: #4670
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]
Re-reviewed
Files changed
in the github PR explorerFor Admin Use: