-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix multisig output #4790
fix multisig output #4790
Conversation
cc: @alexanderbez @jackzampolin maybe we can 🍒 -pick this for |
Codecov Report
@@ Coverage Diff @@
## master #4790 +/- ##
==========================================
+ Coverage 50.46% 50.72% +0.26%
==========================================
Files 288 288
Lines 18571 18563 -8
==========================================
+ Hits 9371 9416 +45
+ Misses 8511 8455 -56
- Partials 689 692 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK -- one minor nitpick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Fixes: #4338
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]
Re-reviewed
Files changed
in the github PR explorerFor Admin Use: