Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multisig output #4790

Merged
merged 4 commits into from
Jul 31, 2019
Merged

fix multisig output #4790

merged 4 commits into from
Jul 31, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jul 26, 2019

Fixes: #4338

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze
Copy link
Collaborator Author

cc: @alexanderbez @jackzampolin maybe we can 🍒 -pick this for 0.36-rc2

@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #4790 into master will increase coverage by 0.26%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #4790      +/-   ##
==========================================
+ Coverage   50.46%   50.72%   +0.26%     
==========================================
  Files         288      288              
  Lines       18571    18563       -8     
==========================================
+ Hits         9371     9416      +45     
+ Misses       8511     8455      -56     
- Partials      689      692       +3

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK -- one minor nitpick

crypto/keys/output.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 7c70912 into master Jul 31, 2019
@alexanderbez alexanderbez deleted the fedekunze/4338-multisig-output branch July 31, 2019 15:47
alexanderbez pushed a commit that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot get pubKeys form multisig (Bech32KeyOutput)
2 participants