Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize store keys in app.go into a map #4800

Merged
merged 6 commits into from
Jul 31, 2019
Merged

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Jul 29, 2019

closes #4611

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #4800 into master will decrease coverage by 0.07%.
The diff coverage is 43.58%.

@@            Coverage Diff             @@
##           master    #4800      +/-   ##
==========================================
- Coverage    50.5%   50.43%   -0.08%     
==========================================
  Files         288      288              
  Lines       18516    18528      +12     
==========================================
- Hits         9351     9344       -7     
- Misses       8480     8499      +19     
  Partials      685      685

@rigelrozanski rigelrozanski marked this pull request as ready for review July 29, 2019 22:59
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending CI fix

@alexanderbez alexanderbez added C:baseapp T: Dev UX UX for SDK developers (i.e. how to call our code) labels Jul 30, 2019
@rigelrozanski
Copy link
Contributor Author

@alexanderbez should be fixed

types/store.go Outdated Show resolved Hide resolved
alexanderbez and others added 2 commits July 30, 2019 12:59
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ⚡️

@alexanderbez alexanderbez merged commit 8f09f1e into master Jul 31, 2019
@alexanderbez alexanderbez deleted the rigel/4611-store-keys branch July 31, 2019 13:59
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:baseapp T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize store keys in app.go into a map
3 participants