Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RegisterEvidences #4846

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 5, 2019

closes: #4843


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #4846 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4846   +/-   ##
=======================================
  Coverage   54.12%   54.12%           
=======================================
  Files         269      269           
  Lines       17216    17216           
=======================================
  Hits         9319     9319           
  Misses       7207     7207           
  Partials      690      690

@alexanderbez alexanderbez merged commit 478eda1 into master Aug 5, 2019
@alexanderbez alexanderbez deleted the bez/4843-register-evidence-cdc branch August 5, 2019 16:42
alexanderbez added a commit that referenced this pull request Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unregistered interface types.Evidence
3 participants