Sim refactor 3: move weighted operations to modules #4869

fedekunze · 2019-08-08T13:20:30Z

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]
Re-reviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

move simulation params back to modules (#4839)

…dekunze/cleanup-genState-generators

…os/cosmos-sdk into fedekunze/move-sim-decoders

x/gov/simulation/operations.go

…dekunze/move-sim-operations

AdityaSripal

Great work. I think the same changes need to be done for proposal weights

x/bank/simulation/operations.go

x/distribution/simulation/proposals.go

…dekunze/move-sim-operations

AdityaSripal

ACK 🎉

alexanderbez

ACK -- although I encourage you address the nitpicks, it's not blocking ;-)

I also recommend that a corresponding PR be opened up against Gaia that points to this branch.

alexanderbez · 2019-12-04T18:56:12Z

types/module/simulation.go

+// GetProposalContents returns each module's proposal content generator function
+// with their default operation weight and key.
+func (sm *SimulationManager) GetProposalContents(simState SimulationState) (wContents []simulation.WeightedProposalContent) {
+	for _, module := range sm.Modules {


nit: don't use a named return value and allocate the array based on size of sm.Modules.

I actually don't know the final size since module.ProposalContents(simState) returns an array

types/module/simulation.go

x/bank/module.go

x/bank/simulation/operations.go

x/distribution/module.go

…smos/cosmos-sdk into fedekunze/move-sim-operations

@colin-axner

* move GenesisState generators to modules * minor change on slashing genState generator * move simulation params back to modules (cosmos#4839) move simulation params back to modules (cosmos#4839) * cleanup params * various fixes * move store decoders to modules * fix * module pattern * split generators for param change * param changes * revert util pkg * banksim * compile * update Decoders params * fix * address @colin-axner comments * move weighted operations to modules * cleanup * cleanup * Update cmd_test.go * simulation manager * mino fixes * cleanup * add GenerateGenesisState to simulation manager * Apply suggestions from code review Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com> * address @rigelrozanski comments * changelog * Apply suggestions from code review Co-Authored-By: colin axner <colinaxner@berkeley.edu> * restructure modules simulation pkgs * remove cycle deps * rename funcs and add missing params * modularize simulator param changes * build * fix params keys * make format * various fixes * fix tests * minor updates to sim_test * cleanup * more cleanup * modularize genesis generators * minor cleanup * remove cdc from generators * remove cdc * add get or generate * fix non-determinism in simulation * changelog and x/simulation godoc * cleanup operations * update operations to use baseapp * updates and cleanup operations * update operations * restructure sim ops params * rename sim /operations/msg.go to /operations.go * move GenTx to a helper pkg to avoid circle deps * rm msg.ValidateBasic * changelog * random fees; delete auth's DeductFees sim operation * add chain-id for sig verification * Update x/simulation/account.go Co-Authored-By: colin axner <colinaxner@berkeley.edu> * fix bank, gov and distr errors * fix staking and slashing errors; increase prob for send enabled * increase gas x10 * make format * fix some distr and staking edge cases * fix all edge cases * golang ci * rename acc vars; default no fees to 0stake * cleanup; check for exchange rate and skip invalid ops * fixes * check for max entries * add pubkey to genaccounts * fix gov bug * update staking sim ops * fix small redelegation error * fix small self delegation on unjail * rm inf loop on random val/accs * copy array * add ok boolean to RandomValidator return values * format * build * add WeightedOperations to AppModuleSimulation * define each module proposals content as part of the module pattern * Update x/bank/simulation/operations.go Co-Authored-By: colin axner <colinaxner@berkeley.edu> * Update simapp/helpers/test_helpers.go Co-Authored-By: colin axner <colinaxner@berkeley.edu> * address @colin-axner comments * add genaccount pubkey validation * fix test * update operations and move RandomFees to x/simulation * update gov ops * address @alexanderbez comments * avoid modifications to config * reorder params * modularized sim operations working * changelog * Update types/module/simulation.go Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com> * Update x/simulation/params.go Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com> * Update x/simulation/params.go Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com> * update /types/module * Update x/distribution/simulation/genesis.go Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * remove named return values * ensure all operations are simulated * golangci * add nolint * disable whitespace and funlen linter * disable godox * add TODO on unjail * update ops weights * remove dup * update godoc * remove unused func * build fixes * move weights to the same file * scopelint * changelog * address @AdityaSripal comments * address @alexanderbez comments

@colin-axner

* move GenesisState generators to modules * minor change on slashing genState generator * move simulation params back to modules (cosmos#4839) move simulation params back to modules (cosmos#4839) * cleanup params * various fixes * move store decoders to modules * fix * module pattern * split generators for param change * param changes * revert util pkg * banksim * compile * update Decoders params * fix * address @colin-axner comments * move weighted operations to modules * cleanup * cleanup * Update cmd_test.go * simulation manager * mino fixes * cleanup * add GenerateGenesisState to simulation manager * Apply suggestions from code review Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com> * address @rigelrozanski comments * changelog * Apply suggestions from code review Co-Authored-By: colin axner <colinaxner@berkeley.edu> * restructure modules simulation pkgs * remove cycle deps * rename funcs and add missing params * modularize simulator param changes * build * fix params keys * make format * various fixes * fix tests * minor updates to sim_test * cleanup * more cleanup * modularize genesis generators * minor cleanup * remove cdc from generators * remove cdc * add get or generate * fix non-determinism in simulation * changelog and x/simulation godoc * cleanup operations * update operations to use baseapp * updates and cleanup operations * update operations * restructure sim ops params * rename sim /operations/msg.go to /operations.go * move GenTx to a helper pkg to avoid circle deps * rm msg.ValidateBasic * changelog * random fees; delete auth's DeductFees sim operation * add chain-id for sig verification * Update x/simulation/account.go Co-Authored-By: colin axner <colinaxner@berkeley.edu> * fix bank, gov and distr errors * fix staking and slashing errors; increase prob for send enabled * increase gas x10 * make format * fix some distr and staking edge cases * fix all edge cases * golang ci * rename acc vars; default no fees to 0stake * cleanup; check for exchange rate and skip invalid ops * fixes * check for max entries * add pubkey to genaccounts * fix gov bug * update staking sim ops * fix small redelegation error * fix small self delegation on unjail * rm inf loop on random val/accs * copy array * add ok boolean to RandomValidator return values * format * build * add WeightedOperations to AppModuleSimulation * define each module proposals content as part of the module pattern * Update x/bank/simulation/operations.go Co-Authored-By: colin axner <colinaxner@berkeley.edu> * Update simapp/helpers/test_helpers.go Co-Authored-By: colin axner <colinaxner@berkeley.edu> * address @colin-axner comments * add genaccount pubkey validation * fix test * update operations and move RandomFees to x/simulation * update gov ops * address @alexanderbez comments * avoid modifications to config * reorder params * modularized sim operations working * changelog * Update types/module/simulation.go Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com> * Update x/simulation/params.go Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com> * Update x/simulation/params.go Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com> * update /types/module * Update x/distribution/simulation/genesis.go Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * remove named return values * ensure all operations are simulated * golangci * add nolint * disable whitespace and funlen linter * disable godox * add TODO on unjail * update ops weights * remove dup * update godoc * remove unused func * build fixes * move weights to the same file * scopelint * changelog * address @AdityaSripal comments * address @alexanderbez comments

fedekunze and others added 20 commits August 2, 2019 16:05

move GenesisState generators to modules

771e305

minor change on slashing genState generator

77d8bd9

move simulation params back to modules (#4839)

52c18e0

move simulation params back to modules (#4839)

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into fe…

bea474f

…dekunze/cleanup-genState-generators

cleanup params

237b65a

various fixes

8bb9880

move store decoders to modules

84fa364

fix

687125a

module pattern

eeb0469

split generators for param change

5fa13a3

param changes

5efe2bd

revert util pkg

3e15e2a

banksim

521c4dd

compile

5c41dd2

update Decoders params

865a5e4

fix

45a0e3c

address @colin-axner comments

da6de9f

merge master

b59f37c

move weighted operations to modules

f25f970

cleanup

66d459a

fedekunze added WIP Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. C:Simulations labels Aug 8, 2019

fedekunze changed the title ~~move sim weighted operations to modules~~ Sim refactor 3: move weighted operations to modules Aug 8, 2019

fedekunze and others added 6 commits August 8, 2019 15:57

merge master

867ba5a

cleanup

4f59730

Update cmd_test.go

bd71a17

merge master

3628d90

Merge branch 'fedekunze/move-sim-decoders' of https://github.com/cosm…

564b484

…os/cosmos-sdk into fedekunze/move-sim-decoders

simulation manager

fc1e72a

fedekunze added 3 commits November 22, 2019 16:10

merge master

3b9b870

build fixes

c16e512

move weights to the same file

a933a05

golangcibot reviewed Nov 26, 2019

View reviewed changes

x/gov/simulation/operations.go Show resolved Hide resolved

scopelint

58357f2

fedekunze requested review from AdityaSripal and removed request for colin-axner November 26, 2019 11:43

fedekunze added R4R and removed WIP labels Nov 26, 2019

fedekunze added 2 commits December 2, 2019 10:36

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into fe…

9e84b66

…dekunze/move-sim-operations

changelog

bfb0a94

AdityaSripal requested changes Dec 2, 2019

View reviewed changes

x/bank/simulation/operations.go Outdated Show resolved Hide resolved

x/distribution/simulation/proposals.go Outdated Show resolved Hide resolved

fedekunze added 2 commits December 3, 2019 10:32

address @AdityaSripal comments

15c015b

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into fe…

a9696c0

…dekunze/move-sim-operations

fedekunze requested a review from AdityaSripal December 3, 2019 09:33

fedekunze modified the milestones: v0.38.0, Simulation state improvements Dec 3, 2019

AdityaSripal approved these changes Dec 3, 2019

View reviewed changes

Merge branch 'master' into fedekunze/move-sim-operations

6ba787d

alexanderbez approved these changes Dec 4, 2019

View reviewed changes

fedekunze and others added 3 commits December 4, 2019 22:24

Merge branch 'master' into fedekunze/move-sim-operations

9ba2ec5

address @alexanderbez comments

cb524e0

Merge branch 'fedekunze/move-sim-operations' of https://github.com/co…

40a38fa

…smos/cosmos-sdk into fedekunze/move-sim-operations

fedekunze mentioned this pull request Dec 4, 2019

update Gaia with to latest SDK master cosmos/gaia#210

Merged

11 tasks

fedekunze merged commit 722a633 into master Dec 5, 2019

fedekunze deleted the fedekunze/move-sim-operations branch December 5, 2019 09:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sim refactor 3: move weighted operations to modules #4869

Sim refactor 3: move weighted operations to modules #4869

fedekunze commented Aug 8, 2019

AdityaSripal left a comment

AdityaSripal left a comment

alexanderbez left a comment •

edited

Loading

alexanderbez Dec 4, 2019

fedekunze Dec 4, 2019

Sim refactor 3: move weighted operations to modules #4869

Sim refactor 3: move weighted operations to modules #4869

Conversation

fedekunze commented Aug 8, 2019

AdityaSripal left a comment

Choose a reason for hiding this comment

AdityaSripal left a comment

Choose a reason for hiding this comment

alexanderbez left a comment • edited Loading

Choose a reason for hiding this comment

alexanderbez Dec 4, 2019

Choose a reason for hiding this comment

fedekunze Dec 4, 2019

Choose a reason for hiding this comment

alexanderbez left a comment •

edited

Loading