Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.13 Upgrade #4989

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Go 1.13 Upgrade #4989

merged 2 commits into from
Sep 4, 2019

Conversation

alexanderbez
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #4989 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4989   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files         284      284           
  Lines       17460    17460           
=======================================
  Hits         9700     9700           
  Misses       7065     7065           
  Partials      695      695

@alexanderbez alexanderbez merged commit 14c555a into master Sep 4, 2019
@alexanderbez alexanderbez deleted the bez/go-1.13-upgrade branch September 4, 2019 14:58
alexanderbez added a commit that referenced this pull request Sep 17, 2019
alexanderbez added a commit that referenced this pull request Sep 17, 2019
@alexanderbez alexanderbez mentioned this pull request Sep 17, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants