Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for halt-time #5005

Merged
merged 12 commits into from
Sep 9, 2019
Merged

Add support for halt-time #5005

merged 12 commits into from
Sep 9, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 5, 2019

closes: #4979


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #5005 into master will decrease coverage by 0.06%.
The diff coverage is 13.79%.

@@            Coverage Diff             @@
##           master    #5005      +/-   ##
==========================================
- Coverage   55.56%   55.49%   -0.07%     
==========================================
  Files         287      287              
  Lines       17521    17540      +19     
==========================================
- Hits         9735     9734       -1     
- Misses       7085     7105      +20     
  Partials      701      701

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. 1 minor nit not blocking

baseapp/abci.go Outdated Show resolved Hide resolved
baseapp/abci.go Outdated Show resolved Hide resolved
@alexanderbez
Copy link
Contributor Author

@tnachen this is a great example of a non-breaking PR that we should get into the next point release (v0.37.1, v0.34.8, and v0.35.0)

@alessio
Copy link
Contributor

alessio commented Sep 6, 2019

I sketched an alternative solution based on goroutine cancellation, which should be a bit safer and cleaner as it does not rely on system-dependant signal implementations: #5010. Downside is that it would introduce a breaking change.

It is a draft and is not meant to replace this PR straightway. I think this PR works, it's not breaking and we should get on with it first, then perhaps work on #5010. Feedback is welcome

@alexanderbez alexanderbez merged commit c8d84b4 into master Sep 9, 2019
@alexanderbez alexanderbez deleted the bez/4979/halt-time-config branch September 9, 2019 14:08
alexanderbez added a commit that referenced this pull request Sep 17, 2019
@alexanderbez alexanderbez mentioned this pull request Sep 17, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Halt at blocktime rather as an alternative to halt at block height
5 participants