-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for halt-time #5005
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5005 +/- ##
==========================================
- Coverage 55.56% 55.49% -0.07%
==========================================
Files 287 287
Lines 17521 17540 +19
==========================================
- Hits 9735 9734 -1
- Misses 7085 7105 +20
Partials 701 701 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. 1 minor nit not blocking
@tnachen this is a great example of a non-breaking PR that we should get into the next point release (v0.37.1, v0.34.8, and v0.35.0) |
I sketched an alternative solution based on goroutine cancellation, which should be a bit safer and cleaner as it does not rely on system-dependant signal implementations: #5010. Downside is that it would introduce a breaking change. It is a draft and is not meant to replace this PR straightway. I think this PR works, it's not breaking and we should get on with it first, then perhaps work on #5010. Feedback is welcome |
closes: #4979
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry to the
Unreleased
section inCHANGELOG.md
Re-reviewed
Files changed
in the github PR explorerFor Admin Use: