Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fixes #5014

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Docs fixes #5014

merged 3 commits into from
Sep 9, 2019

Conversation

gamarin2
Copy link
Contributor

@gamarin2 gamarin2 commented Sep 9, 2019

  • Place translations in /translations folder

  • Remove baseapp_old

  • Reorganise modules and remove duplicate

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fadeev
Copy link
Contributor

fadeev commented Sep 9, 2019

Is it possible that we don't move translations into translations directory? VuePress has a convention about this, which is frankly a pita to overwrite. We will probably have just kr, zh, ru at most and they are unlikely to clash with other directory names.

https://vuepress.vuejs.org/guide/i18n.html

@gamarin2
Copy link
Contributor Author

gamarin2 commented Sep 9, 2019

Yes @fadeev

@jackzampolin
Copy link
Member

Why are the sims failing here?

@gamarin2
Copy link
Contributor Author

gamarin2 commented Sep 9, 2019

Not sure @jackzampolin, see the diff only changes are in /docs

@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #5014 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5014   +/-   ##
======================================
  Coverage    55.5%   55.5%           
======================================
  Files         287     287           
  Lines       17540   17540           
======================================
  Hits         9736    9736           
  Misses       7103    7103           
  Partials      701     701

@jackzampolin jackzampolin merged commit 0992c29 into master Sep 9, 2019
@jackzampolin jackzampolin deleted the gamarin/docs-fixes branch September 9, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants