Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and Utilize GetCommitKVStore #5024

Merged
merged 6 commits into from
Sep 10, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 10, 2019

Keeping the code DRY by utilizing GetCommitKVStore which now does the inter-block cache check/unwrapping. This should guarantee that whenever we get a store in the mapping, it's not wrapped.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #5024 into master will increase coverage by 0.02%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #5024      +/-   ##
==========================================
+ Coverage    55.5%   55.52%   +0.02%     
==========================================
  Files         287      287              
  Lines       17538    17539       +1     
==========================================
+ Hits         9734     9739       +5     
+ Misses       7104     7100       -4     
  Partials      700      700

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alexanderbez alexanderbez merged commit 84627fa into master Sep 10, 2019
@alexanderbez alexanderbez deleted the bez/multi-store-unwrapping branch September 10, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants