Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Events to ABCIMessageLog #5032

Merged
merged 6 commits into from
Sep 12, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 11, 2019

closes: #4990


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #5032 into master will increase coverage by 0.73%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5032      +/-   ##
==========================================
+ Coverage   54.81%   55.55%   +0.73%     
==========================================
  Files         291      287       -4     
  Lines       17844    17541     -303     
==========================================
- Hits         9782     9745      -37     
+ Misses       7357     7096     -261     
+ Partials      705      700       -5

@alexanderbez alexanderbez merged commit 9eb5375 into master Sep 12, 2019
@alexanderbez alexanderbez deleted the bez/4990-message-events-indexing branch September 12, 2019 15:05
alexanderbez added a commit that referenced this pull request Sep 17, 2019
@alexanderbez alexanderbez mentioned this pull request Sep 17, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add message index to each message event
2 participants