-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keys migrate command #5097
Add keys migrate command #5097
Conversation
@alessio tests are failing |
Fixed @fedekunze, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #5097 +/- ##
==========================================
+ Coverage 54.86% 54.87% +0.01%
==========================================
Files 295 296 +1
Lines 18261 18336 +75
==========================================
+ Hits 10019 10062 +43
- Misses 7493 7524 +31
- Partials 749 750 +1 |
841576d
to
5ab4d2a
Compare
This reverts commit 35b5380.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @alessio
Once this is merged, I'll add all remaining commands in an ensuing PR. Once the latter is done, then I'll get on with the following (note: this comment was added by @alexanderbez):
EDIT: @alexanderbez comment is now being addressed in #5104 |
client/keys/migrate.go
Outdated
return err | ||
} | ||
|
||
armoredPriv, err := legacykb.ExportPrivKey(keyName, passwd, "abc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh? Shouldn't we export with a user's encryption passphrase instead of hard-codec "abc"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested ACK 🎉
Add new command to assist users migrate their keys from the legacy
on-disk keybase to the new OS keyring-based implementation.
Ref #4754
docs/
)Unreleased
section inCHANGELOG.md
Files changed
in the github PR explorerFor Admin Use: