Sum validator operator's all voting power #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruihuan
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
alexanderbez
suggested changes
Sep 30, 2019
There was a problem hiding this comment.
I believe the changes to the tally logic are correct. I added a comment and I would also request to add a changelog entry. @sunnya97 does this make sense?
Codecov Report
@@ Coverage Diff @@
## master #5107 +/- ##
=========================================
Coverage ? 53.35%
=========================================
Files ? 290
Lines ? 17696
Branches ? 0
=========================================
Hits ? 9441
Misses ? 7518
Partials ? 737 |
|
bump @Ruihuan on a changelog entry :) |
alexanderbez
suggested changes
Oct 14, 2019
There was a problem hiding this comment.
After reviewing with @rigelrozanski, I believe we need to handle a special case for self-delegation -- i..e we don't want double accounting.
rigelrozanski
suggested changes
Oct 14, 2019
alexanderbez
approved these changes
Oct 15, 2019
sunnya97
previously requested changes
Oct 15, 2019
|
Good catch on the logic bug. Thanks! |
rigelrozanski
approved these changes
Oct 15, 2019
…g power from validator. (cosmos#5107)
|
Mind resolving changelog conflicts @Ruihuan and then we'll get this merged :) |
alexanderbez
dismissed
sunnya97’s stale review
Sunny approved given the changes requested were made which the were.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an address is a validator operator and it's delegated to another validator. When the address vote for a proposal, it just sums the voting power about its own validator. Here should sums its voting power under other validators that delegated to.