Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Fee Delegation #5207

Closed
wants to merge 77 commits into from
Closed

Enable Fee Delegation #5207

wants to merge 77 commits into from

Commits on Oct 16, 2019

  1. Add docs

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    abce938 View commit details
    Browse the repository at this point in the history

  2. Add BasicFeeAllowance implementation

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    ea6fe7d View commit details
    Browse the repository at this point in the history

  3. Add expiration structs and complete basic fee

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    c46153c View commit details
    Browse the repository at this point in the history

  4. Add delegation messages, add validation logic

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    42c17f5 View commit details
    Browse the repository at this point in the history

  5. Add keeper and helper structs

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    0c137cb View commit details
    Browse the repository at this point in the history

  6. Add alias and handler to top level

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    67cb830 View commit details
    Browse the repository at this point in the history

  7. Add delegation module

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    f6ba9bc View commit details
    Browse the repository at this point in the history

  8. Add basic querier

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    a002366 View commit details
    Browse the repository at this point in the history

  9. Add types tests

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    15c6361 View commit details
    Browse the repository at this point in the history

  10. Add types tests

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    410d1f1 View commit details
    Browse the repository at this point in the history

  11. More internal test coverage

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    f65db09 View commit details
    Browse the repository at this point in the history

  12. Solid internal test coverage

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    e0f6327 View commit details
    Browse the repository at this point in the history

  13. Expose Querier to top level module

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    93c9b7e View commit details
    Browse the repository at this point in the history

  14. Add FeeAccount to auth/types, like StdTx, SignDoc

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    7968441 View commit details
    Browse the repository at this point in the history

  15. Fix all tests in x/auth

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    7e82fb8 View commit details
    Browse the repository at this point in the history

  16. All tests pass

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    64d5159 View commit details
    Browse the repository at this point in the history

  17. Appease the Golang Linter

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    8b2b64b View commit details
    Browse the repository at this point in the history

  18. Merge remote-tracking branch 'origin/master' into cg-key-management/f… 

    …ee-delegation-new
    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    4e22edd View commit details
    Browse the repository at this point in the history

  19. Add fee-account command line flag

    @ethanfrey
    ethanfrey committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    be12b44 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Start on DelegatedDeductFeeDecorator

    @ethanfrey
    ethanfrey committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    c703e59 View commit details
    Browse the repository at this point in the history

  2. Cleanup the Decorator

    @ethanfrey
    ethanfrey committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    907776f View commit details
    Browse the repository at this point in the history

  3. Wire up delegation module in simapp

    @ethanfrey
    ethanfrey committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    005afd9 View commit details
    Browse the repository at this point in the history

  4. add basic test for decorator (no delegation)

    @ethanfrey
    ethanfrey committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    45c64d2 View commit details
    Browse the repository at this point in the history

  5. Table tests for deduct fees

    @ethanfrey
    ethanfrey committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    87fd0ce View commit details
    Browse the repository at this point in the history

  6. Table tests over all conditions of delegated fee decorator

    @ethanfrey
    ethanfrey committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    d03c650 View commit details
    Browse the repository at this point in the history

  7. Build full ante handler stack and test it

    @ethanfrey
    ethanfrey committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    e476c03 View commit details
    Browse the repository at this point in the history

  8. Start genesis

    @ethanfrey
    ethanfrey committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    182eb34 View commit details
    Browse the repository at this point in the history

  9. Implement Genesis

    @ethanfrey
    ethanfrey committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    071e111 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into cg-key-management/fee-delegation-new

    @alexanderbez
    alexanderbez authored Oct 17, 2019
    Configuration menu
    Copy the full SHA
    0a362b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Rename package delegation to subkeys

    @ethanfrey
    ethanfrey committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    98b88a3 View commit details
    Browse the repository at this point in the history

  2. Clarify antes test cases, handle empty account w/o fees

    @ethanfrey
    ethanfrey committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    376e9cd View commit details
    Browse the repository at this point in the history

  3. Allow paying delegated fees with no account

    @ethanfrey
    ethanfrey committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    529764f View commit details
    Browse the repository at this point in the history

  4. Pull mempool into delegated ante, for control on StdFee

    @ethanfrey
    ethanfrey committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    d293aae View commit details
    Browse the repository at this point in the history

  5. Use custom DelegatedTx, DelegatedFee for subkeys

    @ethanfrey
    ethanfrey committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    a8b3e31 View commit details
    Browse the repository at this point in the history

  6. Revert all changes to x/auth.StdTx

    @ethanfrey
    ethanfrey committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    e939e98 View commit details
    Browse the repository at this point in the history

  7. Appease scopelint

    @ethanfrey
    ethanfrey committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    6aef5c8 View commit details
    Browse the repository at this point in the history

  8. Register DelegatedTx with codec

    @ethanfrey
    ethanfrey committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    1212772 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into cg-key-management/fee-delegation-new

    @alexanderbez
    alexanderbez authored Oct 18, 2019
    Configuration menu
    Copy the full SHA
    f688116 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Address PR comments

    @ethanfrey
    ethanfrey committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    61df0c6 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary DelegatedMempoolFeeDecorator

    @ethanfrey
    ethanfrey committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    d684f92 View commit details
    Browse the repository at this point in the history

  3. Cleaned up errors in querier

    @ethanfrey
    ethanfrey committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    aacf6fb View commit details
    Browse the repository at this point in the history

  4. Clean up message sign bytes

    @ethanfrey
    ethanfrey committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    92f64cc View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Minor PR comments

    @ethanfrey
    ethanfrey committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    4daf4af View commit details
    Browse the repository at this point in the history

  2. Replace GetAllFees... with Iterator variants

    @ethanfrey
    ethanfrey committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    a497575 View commit details
    Browse the repository at this point in the history

  3. PrepareForExport adjusts grant expiration height

    @ethanfrey
    ethanfrey committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    73eab92 View commit details
    Browse the repository at this point in the history

  4. Panic on de/serialization error in keeper

    @ethanfrey
    ethanfrey committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    546fa8f View commit details
    Browse the repository at this point in the history

  5. Move custom ante handler chain to tests, update docs

    @ethanfrey
    ethanfrey committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    5f9e391 View commit details
    Browse the repository at this point in the history

  6. More cleanup

    @ethanfrey
    ethanfrey committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    c45dc71 View commit details
    Browse the repository at this point in the history

  7. More doc cleanup

    @ethanfrey
    ethanfrey committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    2be48ef View commit details
    Browse the repository at this point in the history

  8. Renamed subkeys module to fee_grant

    @ethanfrey
    ethanfrey committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    e8a624f View commit details
    Browse the repository at this point in the history

  9. Rename subkeys/delegation to fee grant in all strings

    @ethanfrey
    ethanfrey committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    6756099 View commit details
    Browse the repository at this point in the history

  10. Modify Msg and Keeper methods to use Grant not Delegate

    @ethanfrey
    ethanfrey committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    320bad4 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/master' into cg-key-management/f… 

    …ee-delegation-new
    @ethanfrey
    ethanfrey committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    a625fd0 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. Add PeriodicFeeAllowance

    @ethanfrey
    ethanfrey committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    4b4391b View commit details
    Browse the repository at this point in the history

  2. Update aliases

    @ethanfrey
    ethanfrey committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    9ec284b View commit details
    Browse the repository at this point in the history

  3. Cover all accept cases for PeriodicFeeAllowance

    @ethanfrey
    ethanfrey committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    4b34cf6 View commit details
    Browse the repository at this point in the history

  4. Et tu scopelint?

    @ethanfrey
    ethanfrey committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    78f1f7a View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. Update docs as requested

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    a1951b4 View commit details
    Browse the repository at this point in the history

  2. Remove error return from GetFeeGrant

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    17c39ca View commit details
    Browse the repository at this point in the history

  3. Code cleanup as requested by PR

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    9c399bb View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into cg-key-management/f… 

    …ee-delegation-new
    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    6b9e06e View commit details
    Browse the repository at this point in the history

  5. Updated all errors to use new sdk/errors package

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    21b0ac5 View commit details
    Browse the repository at this point in the history

  6. Use test suite for keeper tests

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    2222d0e View commit details
    Browse the repository at this point in the history

  7. Clean up alias.go file

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    eda42d4 View commit details
    Browse the repository at this point in the history

  8. Define expected interfaces in exported, rather than importing from ac… 

    …count
    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    a56b472 View commit details
    Browse the repository at this point in the history

  9. Remove dependency on auth/ante

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    be29328 View commit details
    Browse the repository at this point in the history

  10. Improve godoc, Logger

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    786bf01 View commit details
    Browse the repository at this point in the history

  11. Cleaned up ExpiresAt

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    5f2bcb5 View commit details
    Browse the repository at this point in the history

  12. Improve error reporting with UseGrantedFee

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    314b099 View commit details
    Browse the repository at this point in the history

  13. Enforce period limit subset of basic limit

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    29958e0 View commit details
    Browse the repository at this point in the history

  14. Add events

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    fb5b97a View commit details
    Browse the repository at this point in the history

  15. Rename fee_grant to feegrant

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    eedb8d8 View commit details
    Browse the repository at this point in the history

  16. Ensure KeeperTestSuite actually runs

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    88df255 View commit details
    Browse the repository at this point in the history

  17. Move types/tx to types

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    dbf3578 View commit details
    Browse the repository at this point in the history

  18. Update alias file, include ante

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    375f114 View commit details
    Browse the repository at this point in the history

  19. I do need nolint in alias.go

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    9af9f43 View commit details
    Browse the repository at this point in the history

  20. Properly emit events in the handler. Use cosmos-sdk in amino types

    @ethanfrey
    ethanfrey committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    3c390e5 View commit details
    Browse the repository at this point in the history