Add debug commands #5244
Merged
Add debug commands #5244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved some commands from gaiadebug as commands to be added to applications if they want Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
tac0turtle
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5244 +/- ##
==========================================
+ Coverage 54.71% 54.72% +0.01%
==========================================
Files 307 307
Lines 18304 18304
==========================================
+ Hits 10015 10017 +2
+ Misses 7503 7501 -2
Partials 786 786 |
tac0turtle
force-pushed
the
marko/add_debug-cmds
branch
from
3b9a747 to
f15ec6e
Compare
alessio
reviewed
Oct 25, 2019
alessio
reviewed
Oct 25, 2019
alessio
reviewed
Oct 25, 2019
alessio
reviewed
Oct 25, 2019
alessio
reviewed
Oct 25, 2019
alessio
reviewed
Oct 27, 2019
alexanderbez
suggested changes
Nov 8, 2019
…os-sdk into marko/add_debug-cmds
alessio
reviewed
Nov 9, 2019
alessio
reviewed
Nov 9, 2019
alessio
reviewed
Nov 9, 2019
alessio
reviewed
Nov 9, 2019
alessio
reviewed
Nov 9, 2019
alessio
reviewed
Nov 9, 2019
alexanderbez
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
ACK.
@marbar3778 please create an accompanying PR to add the debug command to Gaia.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should I add some tests to this? may prolong the merge as I have to finish a tutorial
Signed-off-by: Marko Baricevic marbar3778@yahoo.com
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: