Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Module Spec #5294

Merged
merged 11 commits into from
Nov 29, 2019
Merged

Upgrade Module Spec #5294

merged 11 commits into from
Nov 29, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Nov 8, 2019

closes: #5293

/cc @aaronc @ethanfrey


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added T:Docs Changes and features related to documentation. WIP C:x/upgrade labels Nov 8, 2019
@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #5294 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5294   +/-   ##
=======================================
  Coverage   54.78%   54.78%           
=======================================
  Files         307      307           
  Lines       18296    18296           
=======================================
  Hits        10024    10024           
  Misses       7496     7496           
  Partials      776      776

x/upgrade/spec/01_concepts.md Outdated Show resolved Hide resolved
x/upgrade/spec/01_concepts.md Outdated Show resolved Hide resolved
x/upgrade/spec/01_concepts.md Outdated Show resolved Hide resolved
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to mention that a sidecar is needed?

@aaronc
Copy link
Member

aaronc commented Nov 11, 2019

Do we want to mention that a sidecar is needed?

We should say that the sidecar is optional, but we could link to it (https://github.com/regen-network/cosmosd) and mention that it specifies a format for the Plan.Info field that will automatically download binaries: https://github.com/regen-network/cosmosd#auto-download

x/upgrade/abci.go Show resolved Hide resolved
x/upgrade/spec/01_concepts.md Show resolved Hide resolved
x/upgrade/spec/README.md Show resolved Hide resolved
@jackzampolin
Copy link
Member

I like that @aaronc

@alexanderbez alexanderbez mentioned this pull request Nov 24, 2019
13 tasks
@alexanderbez
Copy link
Contributor Author

Added a small section on sidecar process.

@alexanderbez alexanderbez merged commit 3196b7c into master Nov 29, 2019
@alexanderbez alexanderbez deleted the bez/5293-upgrade-mod-spec branch November 29, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/upgrade T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Module Spec
4 participants