-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Module Spec #5294
Upgrade Module Spec #5294
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5294 +/- ##
=======================================
Coverage 54.78% 54.78%
=======================================
Files 307 307
Lines 18296 18296
=======================================
Hits 10024 10024
Misses 7496 7496
Partials 776 776 |
Co-Authored-By: Aditya <adityasripal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to mention that a sidecar is needed?
We should say that the sidecar is optional, but we could link to it (https://github.com/regen-network/cosmosd) and mention that it specifies a format for the |
I like that @aaronc |
Added a small section on sidecar process. |
closes: #5293
/cc @aaronc @ethanfrey
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry to the
Unreleased
section inCHANGELOG.md
Re-reviewed
Files changed
in the github PR explorerFor Admin Use: