Allow node to restart after halt config trigger #5352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
alessio,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5352 +/- ##
==========================================
+ Coverage 54.79% 54.81% +0.01%
==========================================
Files 311 311
Lines 18386 18385 -1
==========================================
+ Hits 10075 10077 +2
+ Misses 7540 7537 -3
Partials 771 771 |
xiangjianmeng
pushed a commit
to xiangjianmeng/cosmos-sdk
that referenced
this pull request
Dec 18, 2019
* Allow node to restart after halt config trigger * Update godoc * Update documentation on halt config
alexanderbez
added a commit
that referenced
this pull request
Dec 18, 2019
* Allow node to restart after halt config trigger * Update godoc * Update documentation on halt config
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the commit ID hash even when gracefully halting a node per configuration which will allow the node to successfully restart and continue processing blocks (if the config has been reset or set to a more distant value).
closes: #5350
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: