R4R: Sortable Decimal Bytes #5360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnya97
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
sunnya97
force-pushed
the
sunny/sortabledecbytes
branch
from
0439790
to
b13cace
Compare
Codecov Report
@@ Coverage Diff @@
## master #5360 +/- ##
==========================================
+ Coverage 54.64% 54.68% +0.04%
==========================================
Files 311 311
Lines 18447 18459 +12
==========================================
+ Hits 10080 10094 +14
+ Misses 7595 7593 -2
Partials 772 772
|
jackzampolin
reviewed
Dec 3, 2019
jackzampolin
reviewed
Dec 3, 2019
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
fedekunze
approved these changes
Dec 4, 2019
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
alexanderbez
reviewed
Dec 4, 2019
karzak
suggested changes
Dec 4, 2019
…smos-sdk into sunny/sortabledecbytes
|
Added tests to check negatives, MaxSortableDec, -MaxSortableDec, and out of bound panics. |
karzak
approved these changes
Dec 4, 2019
xiangjianmeng
pushed a commit
to xiangjianmeng/cosmos-sdk
that referenced
this pull request
Dec 18, 2019
alexanderbez
pushed a commit
that referenced
this pull request
Dec 18, 2019
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function that creates a byte representation of
sdk.Decthat is sortable. Can be used in ordered key queues, so that inserted keys are sorted. Similar to thesdk.SortableTimeFormatfortime.Time.Example use cases:
Orderbooks: https://github.com/sunnya97/sdk-dex-mvp/tree/master/x/orderbook
Kava CDP Liquidation Ratios: Requested by @karzak
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: