Small non-breaking UX changes to keys {list,delete} commands #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
* Add --list-names flag to keys command for short listing. * Make keys delete accept multiple key names at once. Usage example: * gaiacli keys list -n | xargs gaiacli keys delete
alessio
force-pushed
the
alessio/keyring-delete-all-keys
branch
from
f59b4c8
to
631014b
Compare
fedekunze
reviewed
Dec 5, 2019
| return cmd | ||
| } | ||
|
|
||
| func runListCmd(cmd *cobra.Command, args []string) error { | ||
| func runListCmd(cmd *cobra.Command, _ []string) error { |
There was a problem hiding this comment.
we should consider cleaning this in the future
11 tasks
Codecov Report
@@ Coverage Diff @@
## master #5366 +/- ##
==========================================
- Coverage 54.64% 54.64% -0.01%
==========================================
Files 311 311
Lines 18440 18447 +7
==========================================
+ Hits 10077 10080 +3
- Misses 7592 7595 +3
- Partials 771 772 +1
|
alexanderbez
reviewed
Dec 5, 2019
xiangjianmeng
pushed a commit
to xiangjianmeng/cosmos-sdk
that referenced
this pull request
Dec 18, 2019
…5366) Add --list-names flag to keys command for short listing. Make keys delete accept multiple key names at once. Usage example: gaiacli keys list -n | xargs gaiacli keys delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage example:
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)