-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix DecCoins constructor #5410
fix DecCoins constructor #5410
Conversation
for i, coin := range coins { | ||
dcs[i] = NewDecCoinFromCoin(coin) | ||
decCoins := make(DecCoins, len(coins)) | ||
newCoins := NewCoins(coins...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is where coins are sorted
Codecov Report
@@ Coverage Diff @@
## master #5410 +/- ##
=========================================
+ Coverage 54.55% 54.8% +0.24%
=========================================
Files 311 311
Lines 18756 18761 +5
=========================================
+ Hits 10233 10282 +49
+ Misses 7744 7701 -43
+ Partials 779 778 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK -- I think it needs an additional test case for invalid coins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACKed
* fix decCoins * minor changes for standardization * changelog * add test cases
* fix decCoins * minor changes for standardization * changelog * add test cases
Closes: #5408
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)