IBC SDK specification #5426
Merged
IBC SDK specification #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwgoes
reviewed
Jan 2, 2020
| @@ -1,3 +0,0 @@ | |||
| # Cosmos Inter-Blockchain Communication (IBC) Protocol | |||
|
|
|||
There was a problem hiding this comment.
I think it might be worth leaving this - we have linked to this folder before.
There was a problem hiding this comment.
all specs live in the corresponding modules now
There was a problem hiding this comment.
I realise - I mean externally (on some blog posts). Should we link to the new module specs then?
| # State | ||
|
|
||
| The paths for the values stored in state can be found [here](https://github.com/cosmos/ics/blob/master/spec/ics-024-host-requirements/README.md#path-space). Additionally, the SDK adds | ||
| a prefix to the path to be able to aggregate the values for querying purposes. |
There was a problem hiding this comment.
This will no longer be true once the new store layout is implemented, correct?
| The message validates the header and updates the consensus state with the new | ||
| height, commitment root and validator sets, which are then stored. | ||
|
|
||
| ## ICS 03 - Connection |
|
|
||
| ### MsgChannelOpenInit | ||
|
|
||
| A channel handshake is initiated by a chain A using the `MsgChannelOpenInit` |
There was a problem hiding this comment.
Why specifically a "chain A"?
| } | ||
| ``` | ||
|
|
||
| This message is expected to fail if: |
fedekunze
requested review from
alessio,
alexanderbez and
jackzampolin
as code owners
|
I'll merge this since I think it provides value and I will complete this at a later stage once the implementation is stable enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the spec for the
x/ibcmodule within the SDK.For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)