Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards stateful router #5460

Merged
merged 6 commits into from
Jan 2, 2020

Conversation

PumpkinSeed
Copy link
Contributor

@PumpkinSeed PumpkinSeed commented Jan 2, 2020

Closes: #5455

Description

Details in #5458


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@PumpkinSeed PumpkinSeed changed the title I5455 stateful router Towards stateful router Jan 2, 2020
baseapp/baseapp.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #5460 into ctx_msg_router will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ctx_msg_router    #5460      +/-   ##
==================================================
+ Coverage           54.37%   54.39%   +0.01%     
==================================================
  Files                 313      313              
  Lines               18840    18840              
==================================================
+ Hits                10245    10248       +3     
+ Misses               7810     7807       -3     
  Partials              785      785
Impacted Files Coverage Δ
x/mock/app.go 64.18% <0%> (+1.35%) ⬆️
baseapp/options.go 73.13% <0%> (+1.49%) ⬆️

@sunnya97 sunnya97 merged commit ebee7c7 into cosmos:ctx_msg_router Jan 2, 2020
@PumpkinSeed PumpkinSeed deleted the I5455-stateful-router branch January 2, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants