-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nil pointer deref in distribution tax/rewward validation helpers #5620
Conversation
dce0d0a
to
a9e9af7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you allude to when an Int
or Dec
would be Nil
? This should never be the case.
Please reference the issue in the PR body @alessio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Before checking Dec's value, one has to ensure the internal big.Int pointer is not nil first. Closes: #5621
bb967ad
to
4d69262
Compare
@alexanderbez @jackzampolin please have another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alessio please address the scope linting errors in the tests.
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Codecov Report
@@ Coverage Diff @@
## master #5620 +/- ##
==========================================
+ Coverage 44.63% 44.64% +<.01%
==========================================
Files 324 324
Lines 24707 24707
==========================================
+ Hits 11029 11031 +2
+ Misses 12618 12616 -2
Partials 1060 1060
|
Before checking Dec's value, one has to ensure the internal big.Int
pointer is not nil first.
Closes: #5621
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)